feat(proxmox): v1 VM delete + task-status endpoints with protected-VMID guard#93
Merged
pparage merged 2 commits intoJun 9, 2026
Merged
Conversation
added 2 commits
June 8, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /v1/proxmox/hosts/{host_id}/vms/{vmid}— destroys the guest on Proxmox (purge=1+destroy-unreferenced-disks=1whenpurge), with the protected-VMID guard enforced unconditionally on the delete path (VMID 100/101 + canonical ranges + per-host overrides can never be destroyed). Running guest → 409; auth/unreachable/other → existing error envelope.GET /v1/proxmox/hosts/{host_id}/tasks/{upid:path}/status— polls a launched action's UPID to real completion. UPID declared as{upid:path}(colons preserved) and percent-encoded (quote(..., safe='')) for the outbound Proxmox call. NewTaskStatusschema; unexpectedstatusvalues coerced defensively so they can't escape the error envelope as a 500._assert_vmid_safe(row, vmid, action)— behavior preserved forvm_status_action(still gated by_DESTRUCTIVE_ACTIONS), called unconditionally byvm_delete.NameError: Anyon the retired v0 delete path (app/routes/vms.py).These endpoints back the deployer-ui "Proxmox Action Tracking" feature (confirmed delete/lifecycle tracked to task completion via UPID polling).
Test Plan
pytest— 391 passedtest_vm_delete_happy_path(purge params),test_vm_delete_refuses_protected_vmid(VMID 100 → 409, no DELETE reaches Proxmox),test_vm_delete_running_guest_conflict,test_vm_delete_running_guest_qemu_process_phrasingtest_task_status_stopped_ok(percent-encoded UPID in outbound URL),test_task_status_stopped_error,test_task_status_unexpected_status_coerced_to_stoppedtest_vm_action_guards_protected_vmids_on_destructivestill passes (guard refactor behavior-preserving)